Canonical meta tag #898
Merged
Canonical meta tag #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generates a canonical URL for content items based on its web_url combined with a part slug if necessary.
This ensures that a content item with parts will have the correct URL.
kevindew
approved these changes
May 11, 2018
tijmenb
reviewed
May 11, 2018
| <meta property="og:site_name" content="GOV.UK" /> | ||
| <meta property="og:type" content="article" /> | ||
| <meta property="og:url" content="<%= @content_item.web_url %>" /> |
tijmenb
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
May 22, 2018
First implemented in alphagov/government-frontend#898
tijmenb
added a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
May 23, 2018
First implemented in alphagov/government-frontend#898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a canonical URL
linktag to all pages. For content items with parts, it makes sure that the part slug is included at the end of the URL.Trello Card
Visual regression results:
https://government-frontend-pr-898.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-898.herokuapp.com/component-guide