Remove subscription links component #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
remove-subscription-links-component
branch
from
2f8faf2 to
0b2cf90
Compare
andysellick
changed the title
sihugh
approved these changes
May 3, 2018
There was a problem hiding this comment.
I checked this locally and against the PR adding the component to govuk_publishing_components. It looks sensible, renders correctly and removes the same things that were added in the other PR
sihugh
requested changes
May 3, 2018
sihugh
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subscription links component has been moved from this app to the publishing components gem. This PR removes it and updates government-frontend to use the component from the gem.
Trello card: https://trello.com/c/NjgS3vym/55-modify-component-get-updates
Visual regression results:
https://government-frontend-pr-887.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-887.herokuapp.com/component-guide/heading