Remove heading component #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to use component from gem
andysellick
force-pushed
the
use-heading-component-from-gem
branch
from
dc6ffbb to
e50d61f
Compare
andysellick
changed the title
sihugh
approved these changes
May 3, 2018
There was a problem hiding this comment.
I've checked this against the PR to add the component to govuk_publishing_components.
I've looked at some affected pages (like https://www.gov.uk/government/consultations/the-future-for-food-farming-and-the-environment locally - which are fine) and checked that nothing else uses the local component
vanitabarrett
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heading component has been moved from this app to the publishing components gem. This PR removes the heading component and updates government-frontend to use the component from the gem.
Trello card: https://trello.com/c/iehFbdw0/54-modify-component-heading
Visual regression results:
https://government-frontend-pr-885.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-885.herokuapp.com/component-guide/heading