Add structured data for news articles #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijmenb
force-pushed
the
add-structured-data
branch
from
fe9cf3d to
4c73dcf
Compare
tijmenb
changed the title
cbaines
reviewed
Apr 16, 2018
| "dateModified" => presenter.public_updated_at, | ||
| "description" => presenter.description, | ||
| "publisher" => { | ||
| "@type" => "Organization", |
There was a problem hiding this comment.
The indentation looks a little off here.
cbaines
reviewed
Apr 16, 2018
| "@type" => "Organization", | ||
| "name" => publishing_organisation["title"], | ||
| }, | ||
| } |
There was a problem hiding this comment.
I'm no expert on this linked data stuff, but I'd have expected to find at least some URIs in this... maybe that's a future improvement.
cbaines
approved these changes
Apr 16, 2018
This implements a minimum of structured data for news articles. As per Google: > Structured data is a standardized format for providing information about a page and classifying the page content; for example, on a recipe page, what are the ingredients, the cooking time and temperature, the calories, and so on. https://developers.google.com/search/docs/guides/intro-structured-data We use the JSON-LD (JSON "Linked Data", https://json-ld.org) here. It's Google's recommended way of implementing this and avoids a lot of the hassle involved with Microdata, which interleaves the structured data with HTML. The output of this is tested with the Structured data testing tool: https://search.google.com/structured-data/testing-tool Unfortunately, the "publisher" attribute needs a logo. I've chosen the Opengraph image for this because it's not likely to change and will probably stay around for a long time. If we're going to implement more structured data, we'll have to come up with an alternative (and a better image).
tijmenb
force-pushed
the
add-structured-data
branch
from
4c73dcf to
84bcaa3
Compare
|
Thanks @cbaines, updated with extra URLs. Still passes validation: https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Fgovernment-frontend-pr-876.herokuapp.com%2Fgovernment%2Fnews%2Fasian-hornet-identified-in-lancashire |
Good good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a minimum of structured data for news articles.
As per Google:
https://developers.google.com/search/docs/guides/intro-structured-data
We use the JSON-LD (JSON "Linked Data", https://json-ld.org) here. It's Google's recommended way of implementing this and avoids a lot of the hassle involved with Microdata, which interleaves the structured data with HTML.
Unfortunately, the "publisher" attribute needs a logo. I've chosen the Opengraph image for this because it's not likely to change and will probably stay around for a long time. If we're going to implement more structured data, we'll have to come up with an alternative (and a better image).
Testing
The output of this is tested with the Structured data testing tool:
https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Fgovernment-frontend-pr-876.herokuapp.com%2Fgovernment%2Fnews%2Fasian-hornet-identified-in-lancashire
https://trello.com/c/zjcEjaii/5-start-experimenting-with-structured-data