Move content id meta tag #872
Merged
+0
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMoore
force-pushed
the
move-content-id-meta-tag-to-component
branch
from
5cd7ba6 to
1d52cf4
Compare
This is now part of the analytics component alphagov/static#1375 I've removed the test for this because frontend components are faked when running the tests.
MatMoore
force-pushed
the
move-content-id-meta-tag-to-component
branch
from
1d52cf4 to
6bb1f20
Compare
tijmenb
approved these changes
Apr 11, 2018
MatMoore
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now part of the analytics component, which should be deployed at the same time.
alphagov/static#1375
Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide