Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contents list style adjustments #852

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Contents list style adjustments #852

merged 1 commit into from
Mar 28, 2018

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Mar 28, 2018 •
edited
Loading

  • restore underline by default, in line with (growing consensus of) link styles across GOV.UK
  • slightly increase spacing between links on mobile but leave it as it is on desktop. It's still a bit close on mobile, but any further is going to push the height of longer lists of links too much
  • also slightly increase indent spacing on links, to put more space between text and dash

Underline before:

screen shot 2018-03-28 at 14 54 49

screen shot 2018-03-28 at 14 55 21

Underline after:

screen shot 2018-03-28 at 14 55 02

screen shot 2018-03-28 at 14 55 26

Spacing on mobile before:

screen shot 2018-03-28 at 14 56 31

Spacing on mobile after:

screen shot 2018-03-28 at 14 56 42

Component guide for this PR:
https://government-frontend-pr-852.herokuapp.com/component-guide

Trello card: https://trello.com/c/SsXQ1jsD/582-frontend-tweaks-to-the-in-page-chapter-navigation-component

@andysellick
Contents list style adjustments
78aad39 
- restore underline by default, in line with link styles across GOV.UK
- slightly increase spacing between links on mobile
@andysellick andysellick changed the title [DO NOT MERGE] Contents list style adjustments Contents list style adjustments Mar 28, 2018
@andysellick andysellick merged commit 0188ad0 into master Mar 28, 2018
@andysellick andysellick deleted the contents-list-adjustments branch March 28, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tijmenb tijmenb tijmenb approved these changes

@vanitabarrett vanitabarrett vanitabarrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andysellick @tijmenb @vanitabarrett