HUB-90 - https://govukverify.atlassian.net/browse/HUB-90 - #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify trial create account page as the double col layout view has been deemed unsucessful. This undoes the changes made in HUB-39 https://govukverify.atlassian.net/browse/HUB-39 and should revert the page views for the create account pages for the company car tax, personal tax and income tax services to display the content from publisher again. Solo: @rachelthecodesmith
rachelthecodesmith
force-pushed
the
hub-90-tear-down-verify-trial-for-create-account-page
branch
from
c73b15e to
225efd9
Compare
emmabeynon
reviewed
Mar 28, 2018
There was a problem hiding this comment.
Looks good, just wondering if app/assets/stylesheets/views/_service_sign_in.scss is still needed? A quick glance of the original service sign in pages suggests that they doesn't use these styles as it's heavily componentised, but it's worth a check.
If that file is no longer needed, it will need to be removed from app/assets/stylesheets/application.scss.
emmabeynon
deleted the
hub-90-tear-down-verify-trial-for-create-account-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove verify trial create account page as the double col layout view has been deemed unsuccessful. This undoes the changes made in HUB-39 https://govukverify.atlassian.net/browse/HUB-39 and should revert the page views for the create account pages for the company car tax, personal tax and income tax services to display the content from publisher again.
Should now look like the below for each of the three services:
NOTE: There is another PR in Publisher that changes the links to buttons so if that gets merged before this does the links on the below screenshots will appear as buttons. This is intentional.
http://localhost:3090/check-income-tax-current-year/sign-in/create-account
http://localhost:3090/update-company-car-details/sign-in/create-account
http://localhost:3090/personal-tax-account/sign-in/create-account
Solo: @rachelthecodesmith
Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide