Use contextual navigation components #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2018
tijmenb
force-pushed
the
contextual-navigation
branch
from
3200510 to
5086b5c
Compare
vanitabarrett
previously requested changes
Mar 19, 2018
There was a problem hiding this comment.
On contact pages, the navigation sidebar isn't quite in the right place - it should be in line with the start of the paragraph text (just below the title), not above the title.
vs
https://www.gov.uk/dvla-change-address (answer page)
|
@vanitabarrett thank you! updated. |
tijmenb
force-pushed
the
contextual-navigation
branch
from
faa122b to
533dda5
Compare
tijmenb
force-pushed
the
contextual-navigation
branch
from
533dda5 to
8672b4a
Compare
tijmenb
force-pushed
the
contextual-navigation
branch
from
8672b4a to
efda726
Compare
tijmenb
force-pushed
the
contextual-navigation
branch
from
efda726 to
0535030
Compare
tijmenb
force-pushed
the
contextual-navigation
branch
from
0535030 to
1eac408
Compare
This PR uses the contextual navigation sidebar and breadcrumbs from the publishing components gem. It removes all the logic for what to display where and replaces it with calls to the components. The intention is that this PR doesn't change the layout, but there are a few changes: - Contacts have the new sidebar, but the data has stayed the same. I'm unsure why universal layout hadn't been implemented for contacts in the first place, and Ganesh wasn't sure either. This might have been an oversight. - On topical event pages about pages, there's no more "(archived)" in the title when the topical event is archived. I think this is an acceptable trade-off given the complexity it would mean moving this special functionality to the components. - We no longer override the header navigation type for things tagged tagged to the taxonomy. I don't think there was very much reason behind showing it and not showing it, so I'm okay with this change (this is the content_for :simple_header stuff that's removed) - Even though there's a related_items method in the travel advice presenter, it was unused and the travel advice pages are unchanged after this PR. https://trello.com/c/1LEofaHC
tijmenb
force-pushed
the
contextual-navigation
branch
from
1eac408 to
d5b5e93
Compare
sihugh
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the contextual navigation sidebar and breadcrumbs from the publishing components gem (alphagov/govuk_publishing_components#228). It removes all the logic for what to display where and replaces it with calls to the components.
The intention is that this PR doesn't change the layout, but there are a few changes:
The contacts breadcrumb has changed a little bit from "Contact HM Revenue & Customs" to "HM Revenue & Customs Contacts". This is because all contacts have theThe finder has been renamed so there are no more changes now (Rename the finder to "Contact HM Revenue & Customs" contacts-admin#372).parentlink to the contacts finder. I think this is a fine change. If we want to change the title we should change the finder title.content_for :simple_headerstuff that's removed)related_itemsmethod in the travel advice presenter, it was unused and the travel advice pages are unchanged after this PR.Can be reviewed now, but don't merge until it's using a released version of alphagov/govuk_publishing_components#228.
https://trello.com/c/1LEofaHC