Stop using request variants to determine layout #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the code for the taxonomy_navigation requests variants and uses `if` statements in the views instead. This makes it clearer what's going on. It shouldn't make any change in the pages. I suspect that most of these `if` statements aren't actually meaningful and can be removed. That's for a follow up PR.
fofr
approved these changes
Mar 15, 2018
tijmenb
commented
Mar 15, 2018
| @@ -1,15 +0,0 @@ | |||
| <div class="column-third add-title-margin"> | |||
| <% if @navigation.should_present_taxonomy_navigation? %> | |||
There was a problem hiding this comment.
The observant reader will notice that because this partial variant will only be shown when should_present_taxonomy_navigation? is true, this statement will also always be true. The else could never have been executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the code for the taxonomy_navigation requests variants and uses
ifstatements in the views instead.This makes it clearer what's going on. It shouldn't make any change in the pages.
I suspect that most of these
ifstatements aren't actually meaningful and can be removed. That's for a follow up PR.https://trello.com/c/WJlqy3VD