Fix sidebar taxon showing #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the hard things in debugging the problems with the sidebar was that we couldn't determine what the page was supposed to show. This would have been very helpful.
The recent changes to the taxonomy exposed that we have duplicated logic between this application and the components. At the moment this app thinks that there are taxons, so it tries to show the sidebar. However, the `govuk_component/taxonomy_sidebar` component *doesn't* think there are taxons, because it only looks at the live ones. This is a temporary fix, we will re-architect this so that the logic is simple and in only one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to the taxonomy exposed that we have duplicated logic between this application and the components. At the moment this app thinks that there are taxons, so it tries to show the sidebar. However, the
govuk_component/taxonomy_sidebarcomponent doesn't think there are taxons, because it only looks at the live ones.This is a temporary fix, we will re-architect this so that the logic is simple and in only one place. I'm also sad about the lack of failing tests for this.
Before
After