Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component wrapper in published dates component #3486

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

  • modify the published dates component to use the component wrapper helper
  • move the visibly hidden heading inside the component and adjust a test accordingly

Why

This component was using the shared helper for margin bottom but this functionality is being moved to the component wrapper helper.

Visual changes

None.

Trello card: https://trello.com/c/qH4NyWJw/364-add-component-wrapper-to-more-components

Related PR: alphagov/frontend#4543

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3486 December 18, 2024 13:15 Inactive
@andysellick andysellick changed the title Published dates wrapper Use component wrapper in published dates component Dec 18, 2024
@andysellick andysellick force-pushed the published-dates-wrapper branch from a999dd8 to daaf7c3 Compare December 18, 2024 13:17
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3486 December 18, 2024 13:17 Inactive
@andysellick andysellick force-pushed the published-dates-wrapper branch from daaf7c3 to 1dd5045 Compare December 18, 2024 16:03
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3486 December 18, 2024 16:03 Inactive
@andysellick andysellick merged commit 9082d53 into main Dec 19, 2024
11 checks passed
@andysellick andysellick deleted the published-dates-wrapper branch December 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants