Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Welsh translation of the print_entire_guide key #3433

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Nov 21, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

What

A Welsh speaking stakeholder has highlighted the following issue with the translation of page furniture on mainstream content eg https://www.gov.uk/tax-appeals

At the bottom of each English mainstream page, it says: "View a printable version of the whole guide"
And at the bottom of the Welsh page it says "Argraffu’r canllaw cyfan".

While there is nothing inherently wrong with that (the Welsh says “Print the whole guide”), it is different from the English original, which says “View a printable version of the whole guide”.

Why

Trello card

Screenshots

Before

Screenshot 2024-11-21 at 16-13-19 Anghytuno â phenderfyniad treth neu gosb Trosolwg - GOV UK

After

Screenshot 2024-11-21 at 16-16-07 Anghytuno â phenderfyniad treth neu gosb Trosolwg - GOV UK

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3433 November 21, 2024 16:12 Inactive
@unoduetre unoduetre marked this pull request as ready for review November 21, 2024 16:18
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unoduetre unoduetre merged commit d18f12a into main Nov 21, 2024
12 checks passed
@unoduetre unoduetre deleted the 3046-welsh-page-furniture-print-the-whole-guide-s branch November 21, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants