Adjust chat entry component #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesCGDS
changed the title
jon-kirwan
approved these changes
Nov 20, 2024
JamesCGDS
force-pushed
the
adjust_chat_entry_component
branch
from
7e27c85 to
cacbfae
Compare
Removes the blue top border from the chat promo and passing margin_top_until_tablet ultimately increases the margin top to 35px as per the designs
JamesCGDS
force-pushed
the
adjust_chat_entry_component
branch
from
cacbfae to
588affd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the blue border top from the chat entry component and adds a margin top on smaller screen sizes as per the design requirements.
Relies on PR #4417 in the components gem.
Why
Design requirements - trello card
Visual changes
Before (answer page - desktop)
After (answer page - desktop)
Before (answer page - mobile)
After (answer page - mobile)
Before (guidance page - desktop)
After (guidance page - desktop)
Before (guidance page - mobile)
After (guidance page - mobile)