Remove travel advice rendering code #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
changed the title
leenagupte
force-pushed
the
remove-travel-advice-rendering-code
branch
from
d26026a to
87957d8
Compare
leenagupte
force-pushed
the
remove-travel-advice-rendering-code
branch
from
87957d8 to
b9acc6b
Compare
leenagupte
changed the title
KludgeKML
reviewed
Nov 25, 2024
config/routes.rb
Outdated
| @@ -30,7 +30,6 @@ | |||
|
|
|||
| get "*path(.:locale)(.:format)" => "content_items#show", | |||
There was a problem hiding this comment.
I think if the only format allowed was atom, we can also remove the optional format from line 31?
There was a problem hiding this comment.
DONE! And fixed up.
KludgeKML
approved these changes
Nov 25, 2024
leenagupte
force-pushed
the
remove-travel-advice-rendering-code
branch
from
b9acc6b to
25baa25
Compare
Also removes example urls from dev controller.
This component was only being used by the travel advice pages and is no longer needed. It has been moved to frontend.
Atom feeds are only available on travel advice pages. As these pages are being moved to frontend, the entire atom feed set-up can be removed as well. Also updates the controller tests to remove travel advice examples
leenagupte
force-pushed
the
remove-travel-advice-rendering-code
branch
from
25baa25 to
0d2d964
Compare
leenagupte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Dependent on:
What's changed?
Removes the rendering code for travel advice country pages.
Why?
Travel advice rendering is being moved to frontend as of PR alphagov/frontend#4225 so this code will be obsolete.
Follow these steps if you are doing a Rails upgrade.