Fix disappearing Youtube video #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
fix-youtube-video
branch
from
963d687 to
6285c9a
Compare
- on this page https://www.gov.uk/government/publications/electronic-travel-authorisation-eta-help-videos/what-is-an-eta-video there is only an embedded video, which does not appear on mobile - this seems to be due to the `.offset-empty-contents-list` class, which floats the main column right if there is no contents list on the left to push it across - however below desktop this styling persists, when all the grid columns should have collapsed - somehow if there is only a Youtube video present in this floated element, it produces an element with zero width, so the video is effectively invisible - adjusting the class to only apply on desktop seems to fix the issue
andysellick
force-pushed
the
fix-youtube-video
branch
from
6285c9a to
6aed2ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
.offset-empty-contents-listclass, which floats the main column right if there is no contents list on the left to push it acrossHave checked this on some other HTML publications, both with and without contents lists on the left, and the fix seems to not have impacted anything else. I suspect the page where this problem occurs is something of an edge case - if there is any other content with the video it forces a width on the element and all is fine.
Why
This was reported in a basecamp thread: https://3.basecamp.com/4322319/buckets/15005645/messages/7988954800#__recording_7998073365
Visual changes