Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove important metadata component #3414

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Nov 11, 2024

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 12:42 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from 85a1d82 to c8043e0 Compare November 11, 2024 13:28
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 13:28 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from c8043e0 to e3fca48 Compare November 11, 2024 13:38
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 13:38 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from e3fca48 to b08d095 Compare November 11, 2024 14:42
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 11, 2024 14:42 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from b08d095 to eee399b Compare November 12, 2024 11:15
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 12, 2024 11:15 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 12, 2024 14:33 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from f85aed6 to 282fd1e Compare November 12, 2024 15:08
@govuk-ci govuk-ci had a problem deploying to government-frontend-pr-3414 November 12, 2024 15:08 Failure
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from 282fd1e to e31543a Compare November 12, 2024 15:08
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 12, 2024 15:09 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from e31543a to 2cdf473 Compare November 13, 2024 09:39
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 13, 2024 09:39 Inactive
@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from 2cdf473 to 1c51dae Compare November 28, 2024 14:03
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 November 28, 2024 14:03 Inactive
@jon-kirwan jon-kirwan marked this pull request as ready for review November 28, 2024 14:17
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and thanks for providing example URLs 👍 I assume the important-metadata class is needed for testing?

@jon-kirwan
Copy link
Contributor Author

LGTM - and thanks for providing example URLs 👍 I assume the important-metadata class is needed for testing?

Thanks for the review, @AshGDS! That's right. Since there are often two metadata blocks on the same page now - one with 'published' information and the other containing 'important' metadata - the tests need a way to differentiate between them.

@jon-kirwan jon-kirwan force-pushed the remove-important-metadata-component branch from 1c51dae to f602401 Compare December 2, 2024 16:01
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3414 December 2, 2024 16:01 Inactive
@jon-kirwan jon-kirwan merged commit d9eb011 into main Dec 3, 2024
11 checks passed
@jon-kirwan jon-kirwan deleted the remove-important-metadata-component branch December 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants