-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove important metadata component #3414
Conversation
85a1d82
to
c8043e0
Compare
c8043e0
to
e3fca48
Compare
e3fca48
to
b08d095
Compare
b08d095
to
eee399b
Compare
f85aed6
to
282fd1e
Compare
282fd1e
to
e31543a
Compare
e31543a
to
2cdf473
Compare
2cdf473
to
1c51dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - and thanks for providing example URLs 👍 I assume the important-metadata
class is needed for testing?
Thanks for the review, @AshGDS! That's right. Since there are often two metadata blocks on the same page now - one with 'published' information and the other containing 'important' metadata - the tests need a way to differentiate between them. |
1c51dae
to
f602401
Compare
What
Remove important metadata component
Example URLs
Why
It can be replaced with the metadata block component.
Visual changes
Before
After
Before (with title)
After (with title)
Before (with multiple expandable regions)
After (with multiple expandable regions)
Anything else
See:
metadata
component usage govuk_publishing_components#3482