Minor refactor of contents list logic #3363
Merged
+25
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The show_contents_list? method is hard to understand, and bugs have surfaced here. The special logic around showing contents lists on MOJ manual sections only should only be called by the manual section presenter class.
hannako
force-pushed
the
contents_list_refactor
branch
from
a881e8f to
c606970
Compare
beccapearce
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pair programming effort with @CodeSonia
What
This PR contains a minor reorganisation of the existing code with no user facing changes
The show_contents_list? method is hard to understand, and bugs have surfaced here.
The special logic around showing contents lists on MOJ manual sections only should only be called by the manual section presenter class.