Fix markup (and therefore styling) of RTL history mode banner #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
force-pushed
the
fix-rtl-history-mode-banner
branch
from
711a18f to
d6fa599
Compare
ChrisBAshton
force-pushed
the
fix-rtl-history-mode-banner
branch
from
d6fa599 to
8c55f19
Compare
lauraghiorghisor-tw
approved these changes
Oct 1, 2024
Right-to-left languages were displaying the government name in an unusual way, treating the government name as translated text even though it is still English. This commit fixes the text direction, as well as setting the correct language for the text snippet. Before:  After: 
ChrisBAshton
force-pushed
the
fix-rtl-history-mode-banner
branch
from
aadcd87 to
a5425a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on alphagov/publishing-api#2901.
Right-to-left languages were displaying the government name in an unusual way, treating the government name as translated text even though it is still English. This commit fixes the text direction, as well as setting the correct language for the text snippet.
Before:
After:
Trello: https://trello.com/c/dyyPjZxD/2870-history-mode-banners-in-foreign-languages-govt-agency-general-issue
Follow these steps if you are doing a Rails upgrade.