Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take down GOV.UK user research banner for MOD #3342

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Take down GOV.UK user research banner for MOD #3342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions lib/data/recruitment_banners.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,6 @@
# - /foreign-travel-advice

banners:
- name: MOD banner 20/08/2024
suggestion_text: "Help improve GOV.UK"
suggestion_link_text: "Take part in user research (opens in a new tab)"
survey_url: https://submit.forms.service.gov.uk/form/3874/give-feedback-on-medals-information-on-gov-uk/13188
page_paths:
- /guidance/medals-campaigns-descriptions-and-eligibility
- name: HMRC banner 29/08/2024
suggestion_text: "Help improve GOV.UK"
suggestion_link_text: "Sign up to take part in user research (opens in a new tab)"
Expand Down
22 changes: 0 additions & 22 deletions test/integration/recruitment_banner_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,6 @@ def hmrc_banner_survey_url
"https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_74GjifgnGv6GsMC?Source=BannerList_HMRC_CCG_Compliance"
end

test "MOD banner 20/08/2024 is displayed on page of interest" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
path = "/guidance/medals-campaigns-descriptions-and-eligibility"

detailed_guide["base_path"] = path
stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
visit detailed_guide["base_path"]

assert page.has_css?(".gem-c-intervention")
assert page.has_link?("Take part in user research", href: "https://submit.forms.service.gov.uk/form/3874/give-feedback-on-medals-information-on-gov-uk/13188")
end

test "MOD banner 20/08/2024 is not displayed on all pages" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
detailed_guide["base_path"] = "/nothing-to-see-here"
stub_content_store_has_item(detailed_guide["base_path"], detailed_guide.to_json)
visit detailed_guide["base_path"]

assert_not page.has_css?(".gem-c-intervention")
assert_not page.has_link?("Take part in user research", href: "https://submit.forms.service.gov.uk/form/3874/give-feedback-on-medals-information-on-gov-uk/13188")
end

test "HMRC banner 29/08/2024 is displayed on detailed guides of interest" do
detailed_guide = GovukSchemas::Example.find("detailed_guide", example_name: "detailed_guide")
detailed_guide_paths = [
Expand Down
Loading