Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply 'no columns' print style to Guide/Detailed Guide #3337

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

matthillco
Copy link
Contributor

What

Add the new gem-print-columns-none print class to the layouts in Guides and Detailed Guides, to collapse columns on print. Trello

Why

When printing various page types, the 2/3rds + 1/3rds column layout causes issues with cropped content and a generally poor printing experience because the full page isn't used. By selectively collapsing floated columns, we can avoid most of these issues and improve the printing experience by using the full width of the page.

Visual Changes: GUIDE (Portrait)

Before After
image image

Visual Changes: GUIDE (Landscape)

Before After
image image

Visual Changes: DETAILED GUIDE (Portrait)

Before After
image image

Visual Changes: DETAILED GUIDE (Landscape)

Before After
image image

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3337 September 19, 2024 12:00 Inactive
Copy link
Contributor

@AshGDS AshGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Slightly off topic, is the contrast on these numbers good enough for print?
image

Also why are my links when I print blue, and yours grey? Is that just your printer settings set to greyscale?

@matthillco
Copy link
Contributor Author

matthillco commented Sep 19, 2024

Slightly off topic, is the contrast on these numbers good enough for print?

Nice spot, yep I have this in my backlog of other fixes that still need doing, this one slipped through the net.

Also why are my links when I print blue, and yours grey? Is that just your printer settings set to greyscale?

That's curious, links should print as black for everyone, we should compare our setups to find out the differences.

@matthillco matthillco merged commit 894196b into main Sep 19, 2024
12 checks passed
@matthillco matthillco deleted the print-styles-no-columns-guides branch September 19, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants