Fix HTML Publication layout to work with design system columns #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
force-pushed
the
html-publication-columns-fix
branch
from
b0df4d3 to
1607329
Compare
This commit removes some of the rules that were previously set for the `.main-content-container` and instead uses the column rules from `govuk-frontend`. The container has now been renamed as `contents-container` to be consistent with the `contents-list-container`. I had hoped to remove this class entirely, but it's required to apply different float rules when in RTL reading mode. This also adds the new class for collapsing columns to full width when printing.
matthillco
force-pushed
the
html-publication-columns-fix
branch
from
1607329 to
9019d3d
Compare
andysellick
reviewed
Sep 17, 2024
andysellick
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the HTML Publication layout so that it uses the grid layout classes supplied by govuk-frontend. Trello
This commit removes some of the rules that were previously set for the
.main-content-containerand instead uses the column rules fromgovuk-frontend.The
.main-content-containerhas now been renamed ascontents-containerto be consistent with thecontents-list-container. I had hoped to remove this class entirely, but it's required to apply different float rules when in RTL reading mode.This also adds the new class for collapsing columns to full width when printing.
Why
HTML Publication uses some custom classes for managing its layout, but these more-or-less replicate what’s already available with the row/grid layout classes from the design system. These differences affect our ability to improve generic print styles for rows/columns, as well as being harder to maintain.