Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HMRC's UR banner to required pages #3314

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add HMRC's UR banner to required pages #3314

merged 1 commit into from
Sep 3, 2024

Conversation

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3314 August 29, 2024 15:46 Inactive
@hannako hannako force-pushed the add_ur_banner_29_08 branch from 96dcb8d to e1f6f60 Compare August 29, 2024 16:02
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3314 August 29, 2024 16:03 Inactive
Copy link
Contributor

@MartinJJones MartinJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍

Non-blocking, the existing spacing issue with the intervention_banner on mobile and tablet can be fixed by removing the govuk-width-container CSS class from the intervention_banner.html.erb template - https://github.com/alphagov/government-frontend/blob/main/app/views/shared/_intervention_banner.html.erb#L2. This is not required for the intervention banner and will add 15px of left and right margin on mobile/tablet.

I'm happy to create a separate PR for this as well if preferred 😄.

@hannako hannako force-pushed the add_ur_banner_29_08 branch from e1f6f60 to 0a73e6b Compare August 30, 2024 10:24
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3314 August 30, 2024 10:24 Inactive
@hannako
Copy link
Contributor Author

hannako commented Aug 30, 2024

@MartinJJones I've rebased now to include #3315

@hannako hannako marked this pull request as draft August 30, 2024 10:25
@hannako hannako marked this pull request as ready for review September 3, 2024 09:33
@hannako hannako merged commit 15bac1f into main Sep 3, 2024
11 checks passed
@hannako hannako deleted the add_ur_banner_29_08 branch September 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants