Fix: service manual mobile/tablet alignment #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed "govuk-width-container" divs from service_manual_topic and application.html.erb as they were causing alignment issues on mobile and tablet views. This adjustment ensures that content sections are displayed correctly across different devices. - Improved the service manual_phase_label test to handle case sensitivity for "Alpha". Updated the test to ensure Capybara correctly identifies the phase label regardless of case, resolving the previous error.
MartinJJones
approved these changes
Aug 9, 2024
|
Fixes: #3250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Trello card
This PR addresses alignment issues in the service manual pages across mobile and tablet views which was identified in this GitHub issue: #3250
Changes made:
govuk-width-containerdiv fromservice_manual_topic.html.erb: This change fixes the alignment issue of the content of the page.govuk-width-containerdiv fromapplication.html.erb: this adjustment ensures proper alignment of the phase banner with the content in various views.Additional Updates:
service_manual_phase_labeltest: enhanced the test to handle case sensitivity for the "Alpha" phase label, ensuring Capybara correctly identifies the label regardless of its case. This resolves the previous test error where it said it found an instanceit was found 1 time using a case insensitive search and it was found 1 time including non-visible text.).Screenshots:
Service manual page: https://www.gov.uk/service-manual/helping-people-to-use-your-service
Desktop
No change.
Tablet:
Mobile:
I noticed this PR #2988 which also looked at fixing the spacing of the phase banner in HMRC internal manuals. The below shows this is not affected:
HMRC internal manual: https://www.gov.uk/hmrc-internal-manuals/air-passenger-duty/updates
Desktop
No change
Tablet (no change but to show it too)
Mobile (no change but to show it too: