Fix bugs in historical mode banner translations #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2732-history-mode-banners-in-foreign-languages
branch
from
2c8e92d to
2825561
Compare
|
Do these need updating too 🤔 |
Yes, should I do it as a part of this PR? |
unoduetre
force-pushed
the
2732-history-mode-banners-in-foreign-languages
branch
from
2825561 to
2080a9e
Compare
unoduetre
force-pushed
the
2732-history-mode-banners-in-foreign-languages
branch
from
2080a9e to
2b2a42d
Compare
hannako
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
There are rendering anomalies in history mode notification banners for some foreign language pages. Placeholder text is not replaced and some strings are rendered out of the expected order. Examples:
https://www.gov.uk/government/news/uk-and-us-sanction-key-houthi-figures-to-protect-maritime-security-in-the-red-sea.ar
https://www.gov.uk/government/news/his-majesty-the-king-honours-mr-makoto-uchida-president-and-chief-executive-officer-nissan-motor-corporation.ja
This PR fixes the second issue and a similar issue in a different language, but not the first issue as it would require a completely new functionality to be added to whitehall publisher.
The same Japanese page after the change
Why
Trello ticket