Use type=module for application.js #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
MartinJJones
requested changes
Jul 25, 2024
There was a problem hiding this comment.
The code changes look to me 👍
The JS error in the browser relates to the closest polyfill, further info here - alphagov/smart-answers#6846 (review)
I'm happy to give this another look and approve when the new version of the gem is released and included in this PR as this should then resolve the issue.
Used request changes to avoid anyone helpfully merging
AshGDS
force-pushed
the
type-module-changes
branch
from
c5ae9ae to
eb5ee8d
Compare
MartinJJones
approved these changes
Aug 15, 2024
AshGDS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
staticfirst before this is merged.es6-components.jsagain as a separate task unless you disagree with thisgovuk_publishing_componentsbranch linked above. If you test without this, this app'sapplication.jsseems to crash.