HMRC Manuals: Do not show the title of a section group if the group is empty #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2681-hmrc-manuals-do-not-show-the-title-of-a-section-group-if-its-empty-s-m
branch
from
f5ca3a5 to
fe1bae9
Compare
MartinJJones
approved these changes
Jul 16, 2024
unoduetre
deleted the
2681-hmrc-manuals-do-not-show-the-title-of-a-section-group-if-its-empty-s-m
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
In the content item for this page:https://www.gov.uk/hmrc-internal-manuals/capital-gains-manual the second
child_section_groupcontains a title field, but an emptychild_section_grouparray. Which renders a random looking “Updates” heading underneath the list of sections.Why
It’s confusing, and probably an accessibility fail.
Trello ticket