Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAC audit fix: Add hidden heading above email sign up and print link #3261

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

hannako
Copy link
Contributor

@hannako hannako commented Jul 10, 2024

What

Add a hidden H2 above the email signup and or print link on many page types.

Why

To fix an accessibility fail

Trello

Review app links:

Guidance (without an email signup button) https://government-frontend-pr-3261.herokuapp.com/guidance/dvsa-email-alerts
Guides (schema: publication): Who can get a Blue Badge
Detailed guides: Online immigration status (eVisa)
Consultations: Smarter regulation: deregulating the commercial agents regulations
Call for Evidence: CyberFirst programme: call for views

hannako added 2 commits July 10, 2024 15:44
The DAC audit flagged that the lack of heading between page content
and the published dates/button group is confusing to screen readers.
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3261 July 10, 2024 14:52 Inactive
@hannako hannako marked this pull request as ready for review July 10, 2024 14:56
@hannako hannako requested a review from hannalaakso July 10, 2024 14:58
Copy link
Member

@hannalaakso hannalaakso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it matches the approach elsewhere where we have a visually hidden h2 👍 I've checked that the heading is announced correctly by JAWS, NVDA and Mac Voiceover.

@hannako hannako merged commit b2069b5 into main Jul 11, 2024
12 checks passed
@hannako hannako deleted the hidden_heading_published_dates branch July 11, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants