Fix oversized images #3258
Merged
Fix oversized images #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix oversized images on the 'how government works' page https://www.gov.uk/government/how-government-works - remove hard coded image dimensions and add a class that sets `max-width: 100%` - was causing the images to overlap the width of the screen at small screen sizes, causing a horizontal scroll bar and a broken layout - only adding the class or only removing the width/height don't fix the problem, because width/height as inline attributes override CSS - was hoping to be able to leave the width/height to reduce cumulative layout shift when loading, but this is a small loss compared to fixing the general appearance - surprised we don't have a general class to have all `img` tags with `max-width: 100%` but since there isn't one I don't want to try introducing one here as proving it's fine on every page is a much bigger task (although logically it should be... right?)
maxgds
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
max-width: 100%imgtags withmax-width: 100%but since there isn't one I don't want to try introducing one here as proving it's fine on every page is a much bigger task (although logically it should be... right?)Page with the problem: https://www.gov.uk/government/how-government-works
(I've checked for other image tags within
government-frontendand this seems to be the only instance of this problem)Example of the problem:
Visual changes
Trello card: https://trello.com/c/USYdcgFe/235-image-off-the-right-hand-side-of-the-screen