Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle manual updates on same day correctly #3232

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

KludgeKML
Copy link
Contributor

@KludgeKML KludgeKML commented Jun 17, 2024

  • Previously manual updates to the same path on the same day were grouped together and only the last was shown, despite all being present in the content item. The grouping code was correct, but in the view only the last item was displayed.

Fixes: https://govuk.zendesk.com/agent/tickets/5624376

Before and after from: https://www.gov.uk/guidance/style-guide/updates

Before

Screenshot 2024-06-17 at 14 16 49

After

Screenshot 2024-06-17 at 14 17 03

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3232 June 17, 2024 12:38 Inactive
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3232 June 17, 2024 13:08 Inactive
- Previously manual updates to the same path on the same day were grouped together and only the last was shown, despite all being present in the content item. The grouping code was correct, but in the view only the last item was displayed.

https://govuk.zendesk.com/agent/tickets/5624376
@KludgeKML KludgeKML force-pushed the fix-manual-updates-same-day branch from 3a2ac5e to 9d002ca Compare June 17, 2024 13:17
@KludgeKML KludgeKML marked this pull request as ready for review June 17, 2024 13:18
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3232 June 17, 2024 13:18 Inactive
@KludgeKML KludgeKML merged commit 461db7a into main Jun 17, 2024
11 checks passed
@KludgeKML KludgeKML deleted the fix-manual-updates-same-day branch June 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants