Fix components test #3220
Merged
Fix components test #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- needle and haystack were the wrong way around for the assert_no_match, which meant the test always passed - the `not_applicable` part of this test works in Rspec, which this test was originally written in, but is completely ignored in minitest (it's not useful anyway, the govspeak component isn't in this application)
- doesn't seem like important_metadata needed the html_safe on it - updated YML example to show links rendered correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Fix the all components test in
government-frontend. See commit for detail. Also updates some components to allow this test to pass (it should have been failing, but the components test was broken).Thanks to @KludgeKML for noticing this and writing the fix.
Visual changes
None.
Trello card: https://trello.com/c/N3eQJZlU/168-fix-application-component-tests