Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use components for calls for evidence #3219

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Use components for calls for evidence #3219

merged 2 commits into from
Jun 12, 2024

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Jun 7, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Output attachments in call for evidence pages using the data from the content item, rather than the pre-rendered markup from the content item, and apply GA4 tracking to those attachments that contain Details elements.

This follows on from the work to convert publications in the same manner: #3058

Attachments on consultation pages can occur in two places, so this is a bit more complex than publications, although some of the code and tests have been copied from that previous work.

Example pages to test with:

Why

This work is for two reasons:

  • to convert the rendering of attachments to using components so that tracking can be added to Details elements within attachments (for the 'Request an accessible format' element)
  • to generally move away from the use of pre-rendered markup passed through content items

Visual changes

None, except PDF custom thumbnails are intentionally no longer shown.

Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments

- output attachments in calls for evidence using the data from the content item, rather than the pre-rendered markup from the content item
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3219 June 7, 2024 15:33 Inactive
@andysellick andysellick force-pushed the cfe-use-components branch from 842c434 to fdd3a8b Compare June 7, 2024 16:27
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3219 June 7, 2024 16:27 Inactive
@andysellick andysellick marked this pull request as ready for review June 7, 2024 16:44
@andysellick andysellick requested a review from KludgeKML June 7, 2024 16:44
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andysellick andysellick merged commit 2ef9e5e into main Jun 12, 2024
11 checks passed
@andysellick andysellick deleted the cfe-use-components branch June 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants