Remove publisher metadata component #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
remove-publisher-metadata-component
branch
from
705a04c to
db38e65
Compare
|
Nice work @andysellick I think you also have phrases in the locale files to remove for this (I searched for publisher_metadata) There is also this line to adjust: I think other search matches to publisher_metadata were unrelated. |
- appears to not be in use - functionality can be reproduced using the metadata component from govuk_publishing_components
andysellick
force-pushed
the
remove-publisher-metadata-component
branch
from
db38e65 to
ccaff84
Compare
- remove text for publisher metadata component
andysellick
force-pushed
the
remove-publisher-metadata-component
branch
from
ccaff84 to
7680daa
Compare
|
Thanks @kevindew have updated 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Remove the 'published metadata' component: https://govuk-government-frontend.herokuapp.com/component-guide/publisher_metadata
govuk_publishing_componentsif we need itVisual changes
None. This is what the component looks like (for some reason styles don't work properly for it in the government-frontend component guide).