Use components for consultation attachments #3181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Output attachments in consultation pages using the data from the content item, rather than the pre-rendered markup from the content item, and apply GA4 tracking to those attachments that contain Details elements.
This follows on from the work to convert publications in the same manner: #3058
Attachments on consultation pages can occur in three places, so this is a bit more complex than publications, although some of the code and tests have been copied from that previous work.
Example pages to test with:
Note: an interesting side point on margin - there's some code for logic around a margin to appear beneath boxes that appear at the top of in-progress consultations ('We are analysing your feedback') so that spacing is only applied if there's stuff beneath it. Pretty sure I've preserved the logic but worth checking.
Why
This work is for two reasons:
Visual changes
Mostly should be no visual changes, however this change does remove custom thumbnails for PDFs (as previously removed for publications). This has been agreed and widely discussed around the previous work.
Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments