Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change National Statistics to Accredited Official Statistics #3177

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented May 2, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

What

Office for National Statistics are changing the way that statistics are presented to users.
That means that statistics that are currently referred to as National Statistics will become Accredited Official Statistics and will have a new badge image associated with them.

Here’s an example of one of the pages:
https://www.gov.uk/government/statistics/births-in-england-and-wales-2022-refreshed-populations

Tasks for homepage

  1. Replace the image in government-frontend
  2. Update the image alt-text in government-frontend
  3. Update the display name in the locale files, including the Welsh translation, in government-frontend

Why

So users see the most up to date branding and know to trust this page

Trello ticket

Screenshots

Before

stat-before

mobile-en

After

stat-after

stat-cy

mobile-en

After cropping:

001
002

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 May 2, 2024 15:46 Inactive
@unoduetre unoduetre force-pushed the 2560-prepare-for-ons-badge-image-change-s branch from 685fc59 to 23bea26 Compare May 2, 2024 15:48
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 May 2, 2024 15:48 Inactive
@unoduetre unoduetre force-pushed the 2560-prepare-for-ons-badge-image-change-s branch from 23bea26 to 8e13016 Compare May 2, 2024 16:07
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 May 2, 2024 16:07 Inactive
@unoduetre unoduetre marked this pull request as ready for review May 3, 2024 08:59
Copy link
Contributor

@beccapearce beccapearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes look good to me!

@unoduetre
Copy link
Contributor Author

This PR is waiting for the final confirmation of the icon sizes and one of the translations.

@unoduetre unoduetre force-pushed the 2560-prepare-for-ons-badge-image-change-s branch from 8e13016 to 444c9ee Compare May 16, 2024 10:35
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 May 16, 2024 10:36 Inactive
@hannako hannako marked this pull request as draft May 29, 2024 18:06
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 June 5, 2024 13:04 Inactive
@unoduetre unoduetre force-pushed the 2560-prepare-for-ons-badge-image-change-s branch from 58796e8 to 0079f65 Compare June 5, 2024 13:04
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 June 5, 2024 13:04 Inactive
@unoduetre
Copy link
Contributor Author

I've cropped the images.

@unoduetre unoduetre force-pushed the 2560-prepare-for-ons-badge-image-change-s branch from 0079f65 to 5af4323 Compare June 5, 2024 13:23
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3177 June 5, 2024 13:23 Inactive
@unoduetre unoduetre marked this pull request as ready for review June 7, 2024 07:58
@unoduetre unoduetre merged commit 05dc72d into main Jun 7, 2024
11 checks passed
@unoduetre unoduetre deleted the 2560-prepare-for-ons-badge-image-change-s branch June 7, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants