Add GA4 tracking to details in attachments #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
ga4-attachments-details
branch
from
764d90a to
b19b4be
Compare
AshGDS
approved these changes
Apr 22, 2024
| @@ -14,6 +14,10 @@ def attachments_for_components | |||
| documents.select { |doc| featured_attachments.include? doc["id"] } | |||
| end | |||
|
|
|||
| def attachments_with_details | |||
| attachments_for_components.select { |doc| doc["accessible"] == false && doc["alternative_format_contact_email"] }.count | |||
There was a problem hiding this comment.
This is more for my own curiosity - could doc["accessible"] == false be shortened to !doc["accessible"], or does it need to specifically be a false boolean?
There was a problem hiding this comment.
I think it needs to be a false boolean, but @KludgeKML can confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
Add GA4 tracking attributes to details components within attachment components on publication pages.
The tracking for the details components is mostly handled automatically, but the component can't determine the value for
index_section_count(the total number of related things being tracked) so this must be passed to the component. In this case it is the number of attachments that have a details component showing, which is not necessarily the same as the total number of attachments.Some example pages to test:
Also removes some unnecessary data from the tests in the same file.
Visual changes
None.
Trello card: https://trello.com/c/xhASj1rp/765-add-tracking-to-details-component