Prevent hyphens being read out by screen readers #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannako
reviewed
Apr 23, 2024
beccapearce
force-pushed
the
ensure-dashes-no-read-in-corporate-information
branch
from
a051f70 to
955b1c4
Compare
beccapearce
force-pushed
the
ensure-dashes-no-read-in-corporate-information
branch
from
955b1c4 to
eefb14e
Compare
Use the publishing components `list` to render corporate information page links on the worldwide_organisation show page. this component will stop the hyphens in lists from being read out by screenreaders by replacing them with bullet points. Also added a method to return the corporate information pages as a list of hyperlinks (as expected by the component).
beccapearce
force-pushed
the
ensure-dashes-no-read-in-corporate-information
branch
from
eefb14e to
1298397
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use the
listfromgovuk-publishing-componentto render the list of corporate information pages for worldwide organisations.Why
The list component means we can remove the hyphens that were rendered previously. These were read out as either “dash“ or “hyphen“ before each item/link in the Corporate information list. Screen reader users found that frustrating to read through, so this should improve the experience.
Screenshots
Trello card: https://trello.com/c/pVeGF0WE