Fix publication attachments #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
requested review from
leenagupte and
KludgeKML
and removed request for
leenagupte
- simplify and fix the code to display attachments on publication/form pages - move most of the code into the presenter, to reduce ambiguity - pass only one thing to the attachments_list component - update tests
andysellick
force-pushed
the
fix-publication-attachments
branch
from
3f51fd5 to
1af04c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Follows on from the work done in #3058
Why
Recent changes to rendering of publication attachments were not fully correct, as reported in zendesk ticket https://govuk.zendesk.com/agent/tickets/5807151 and elsewhere.
Specifically:
Visual changes
See 'why'.
Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments