Correctly display 'request accessible format' option #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
approved these changes
Apr 17, 2024
leenagupte
reviewed
Apr 17, 2024
- attachments on publications should only show this option when 'accessible' is false and email address is supplied - including tests accordingly
andysellick
force-pushed
the
fix-attachment-request-options
branch
from
fb3c004 to
7c71da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Follows on from #3058 where this problem was introduced, see that PR for example pages.
Why
Issue raised in zendesk: https://govuk.zendesk.com/agent/tickets/5807086
Visual changes
Fewer attachments should now display this option.
Trello card: https://trello.com/c/tcTN1jbu/28-update-rendering-of-govspeak-attachments