Add support for worldwide offices embedded in worldwide organisations #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
use-ww-office-multipart
branch
from
fa8e8e4 to
4387232
Compare
brucebolt
force-pushed
the
use-ww-office-multipart
branch
from
4387232 to
d0134b7
Compare
We are changing the content item for Worldwide Organisations and Worldwide Offices to be a single piece of content, with all sub-pages included in a single Worldwide Organisation content item. Therefore switching the Worldwide Organisation page to get the office information from the `details`, rather than `links`.
brucebolt
force-pushed
the
use-ww-office-multipart
branch
from
d0134b7 to
d8bb67c
Compare
brucebolt
force-pushed
the
use-ww-office-multipart
branch
from
d8bb67c to
6a61980
Compare
jkempster34
reviewed
Feb 15, 2024
brucebolt
force-pushed
the
use-ww-office-multipart
branch
from
6a61980 to
7250a77
Compare
Looks like that got lost in a rebase 🤦♂️. Have added it back in. |
As part of the switch to Worldwide Organisation content items containing the content for their offices, we need to switch the rendering of the office pages to use these parts. This makes that switch in a backward compatible way, so we can continue rendering office pages under the existing content items until the office routes are updated to point to the organisation's content item. In a later PR, we will remove `WorldwideOfficePresenter` and it's associated view.
brucebolt
force-pushed
the
use-ww-office-multipart
branch
from
7250a77 to
0c88e11
Compare
brucebolt
added a commit
that referenced
this pull request
Feb 21, 2024
In #3095, we introduced code that supports Worldwide Offices being included in the Worldwide Organisation content item, whilst also supporting standalone Worldwide Office content items. We have now removed all the Worldwide Office content items and the code that renders them, so can remove the rendering code from this application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the switch to Worldwide Organisation content items containing the content for their offices, we need to switch the rendering of the Worldwide Organisation and Worldwide Office pages to use these parts.
This makes that switch in a backward compatible way, so we can continue rendering office pages under the existing content items until the office routes are updated to point to the organisation's content item.
In a later PR, we will remove
WorldwideOfficePresenterand it's associated view, once all the routes for offices have been switched.Trello card
Depends on alphagov/publishing-api#2638, alphagov/whitehall#8844 and all Worldwide Organisations being republished.
Follow these steps if you are doing a Rails upgrade.