Remove app error component #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
remove_app_error_component
branch
from
a8b5375 to
70d1d28
Compare
jon-kirwan
force-pushed
the
remove_app_error_component
branch
from
70d1d28 to
75f5063
Compare
jon-kirwan
force-pushed
the
remove_app_error_component
branch
from
75f5063 to
059ab86
Compare
jon-kirwan
force-pushed
the
remove_app_error_component
branch
from
059ab86 to
9d1c301
Compare
MartinJJones
approved these changes
Feb 6, 2024
Only used by the error component (now removed)
jon-kirwan
force-pushed
the
remove_app_error_component
branch
from
9d1c301 to
4e4f628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove application error component and replace with the error formatting option (
error_message) of the radio button component.Review URL: https://government-frontend-pr-3074.herokuapp.com/claim-rural-payments/sign-in/prove-identity
Why
Reduce duplication, align with styles and patterns used elsewhere and deprecate unneeded frontend code.
Visual changes
Before
After
Anything else
There is a small visual difference in that the error includes a red border to visually connect the message and the question it belongs to (as described in the error message component design system guidance).
See alphagov/govuk_publishing_components#3488