Remove code for rendering non-edition links for worldwide organisations #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
add-wworg-edition-links
branch
from
494dc83 to
ef6aa6a
Compare
brucebolt
force-pushed
the
remove-wworg-non-edition-links
branch
from
fd05a6d to
6cad29a
Compare
brucebolt
force-pushed
the
remove-wworg-non-edition-links
branch
2 times, most recently
from
75bfb0e to
48e1713
Compare
In #3055, we added support for edition links associated with worldwide organisations. This change included backward compatibility for worldwide organisations without edition links. Once the worldwide organisations have all been republished without non-edition links, we no longer need the backward compatibility here. This also simplifies the code slightly, as the content item now only contains roles that are relevant to the worldwide organisation, rather than needing to filter them on the frontend.
brucebolt
force-pushed
the
remove-wworg-non-edition-links
branch
from
48e1713 to
e35ec8a
Compare
|
The failing tests will pass once alphagov/publishing-api#2601 is merged, as that updates the examples to match the new type of links. |
callumknights
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3055, we added support for edition links associated with worldwide organisations. This change included backward compatibility for worldwide organisations without edition links.
Once the worldwide organisations have all been republished without non-edition links, we no longer need the backward compatibility here.
This also simplifies the code slightly, as the content item now only contains roles that are relevant to the worldwide organisation, rather than needing to filter them on the frontend.
Trello card
Follow these steps if you are doing a Rails upgrade.