Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video tracking #3054

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix video tracking #3054

merged 1 commit into from
Jan 22, 2024

Conversation

andysellick
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Fix video tracking on AB test variants of:

by doing the following:

  • replaces the existing markup with the markup of the govspeak component, so that when rendered it will initialise the component JS correctly and include GA4 video tracking
  • not the best way of doing our components but limited by how this page is rendered

I can't get the AB variant to work locally so I've not been able to fully test this, although I've inserted the markup into a visible page and it seems to be correct.

Related to alphagov/frontend#3931

Why

Video tracking is required on these pages.

Visual changes

Shouldn't be any, although the video may appear slightly differently/better.

Trello card: https://trello.com/c/rHlNjPxe/775-video-tracking-not-working-on-a-b-test-pages

- replaces the existing markup with the markup of the govspeak component, so that when rendered it will initialise the component JS correctly and include GA4 video tracking
- not the best way of doing our components but limited by how this page is rendered
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3054 January 22, 2024 13:38 Inactive
Copy link
Contributor

@davidtrussler davidtrussler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it does what's required WRT tracking (and is more elegant than the current implementation). Nice! 👍

@andysellick andysellick merged commit bc185e1 into main Jan 22, 2024
13 checks passed
@andysellick andysellick deleted the fix-video-tracking branch January 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants