Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document collections are showing misleading "last updated" data for mainstream content #3041

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

georges1996
Copy link
Contributor

@georges1996 georges1996 commented Jan 11, 2024

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3041 January 11, 2024 08:11 Inactive
@georges1996 georges1996 requested a review from hannako January 11, 2024 15:57
@georges1996 georges1996 changed the title Document collections are showing misleading "last updated" data for mainstream content [M] Document collections are showing misleading "last updated" data for mainstream content Jan 11, 2024
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple of minor suggestions.

Also could you stick a link to the review app for the HMRC pages that are listed in the related ticket

app/presenters/document_collection_presenter.rb Outdated Show resolved Hide resolved
@georges1996 georges1996 force-pushed the misleading-last-updated-date branch from a4e9bf3 to 027fc60 Compare January 12, 2024 13:11
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3041 January 12, 2024 13:12 Inactive
@georges1996 georges1996 requested a review from hannako January 12, 2024 13:12
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, awaiting Jen and others give the green light before merging.

@georges1996 georges1996 merged commit 53c7a4a into main Feb 2, 2024
12 checks passed
@georges1996 georges1996 deleted the misleading-last-updated-date branch February 2, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants