Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for download link for travel advice map #3031

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

davidgisbey
Copy link
Contributor

Description

FCDO would like the copy of this link updated to be more specific. Zendesk ticket: https://govuk.zendesk.com/agent/tickets/5495177

Trello card

https://trello.com/c/acKHf0Md/2281-change-link-title-to-download-a-more-detailed-map

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3031 January 3, 2024 12:26 Inactive
FCDO would like the copy of this link updated to be more specific.
Zendesk ticket: https://govuk.zendesk.com/agent/tickets/5495177
@davidgisbey davidgisbey force-pushed the update-copy-of-download-map-text branch from 710a66d to 5e2aae9 Compare January 3, 2024 12:32
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3031 January 3, 2024 12:32 Inactive
@minhngocd
Copy link
Contributor

All looks good, but the zendesk ticket link seems to be a different one to the one in the trello card

@davidgisbey
Copy link
Contributor Author

davidgisbey commented Jan 3, 2024

Thanks for the review!

So i did a bit of a dig into this because i wasn't massively familiar with it tbh. It looks like there's 2 places that you can access that PDF. One is via Travel Advice Publisher. You can download a PDF of the edition. This PDF has a download link which grabs the pdf from Asset Manager.

The other download link is on GOV.UK which is rendered via Government Frontend. The Zendesk ticket is referencing the GOV.UK one. The example they use is this page https://www.gov.uk/foreign-travel-advice/nigeria.

Maybe i overstepped doing it in both places, but it felt like it was probably useful info for people downloading a superseded edition via Travel Advice Publisher too. I don't think it can hurt anyway.

@davidgisbey davidgisbey merged commit bdb9c67 into main Jan 3, 2024
12 checks passed
@davidgisbey davidgisbey deleted the update-copy-of-download-map-text branch January 3, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants