Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry up Recruitment Banner logic #3028

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Dry up Recruitment Banner logic #3028

merged 1 commit into from
Jan 4, 2024

Conversation

georges1996
Copy link
Contributor

@georges1996 georges1996 commented Dec 28, 2023

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

How

To add a yml file and dry up the code to make it easier to update banners

Only caveat is you will need to add:

<%= render partial: 'shared/intervention_banner' %> to the view you want the banner to be shown on
and add include RecruitmentBannerHelper to the needed controller

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3028 December 28, 2023 11:10 Inactive
@georges1996 georges1996 force-pushed the dry-recruitment-banner branch from f9f26e0 to 4d70fe5 Compare December 28, 2023 11:13
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3028 December 28, 2023 11:14 Inactive
@georges1996 georges1996 requested a review from hannako December 29, 2023 09:39
@georges1996 georges1996 force-pushed the dry-recruitment-banner branch from 4d70fe5 to 0620fc9 Compare December 29, 2023 12:47
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3028 December 29, 2023 12:47 Inactive
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks George - would be good to add tests that the banner is visible on all pages of interest

@georges1996
Copy link
Contributor Author

Thanks George - would be good to add tests that the banner is visible on all pages of interest

There is already tests testing this here: test/integration/recruitment_banner_test.rb

@georges1996 georges1996 requested a review from hannako January 2, 2024 14:28
@georges1996 georges1996 force-pushed the dry-recruitment-banner branch from 0620fc9 to d99cbbb Compare January 3, 2024 06:12
@georges1996 georges1996 requested a review from hannako January 3, 2024 06:12
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3028 January 3, 2024 06:12 Inactive
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georges1996 georges1996 merged commit b39ff99 into main Jan 4, 2024
12 checks passed
@georges1996 georges1996 deleted the dry-recruitment-banner branch January 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants