Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ga4_tracking: true component options #2992

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Nov 17, 2023

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Removes all instances of ga4_tracking: true in calls to components.

  • all components that previously accepted this option now have GA4 tracking enabled by default, so these options are no longer needed
  • no tracking should change as a result of this change
  • this change was made in components gem v 35.22.0

Why

We're moving to an 'opt out' model of component inclusion, to future proof tracking as the site changes and components are added and removed.

Visual changes

None.

Trello card: https://trello.com/c/Xwp7dgJN/294-tracking-auditing-tracking-by-default

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2992 November 17, 2023 14:05 Inactive
- all components that previously accepted this option now have GA4 tracking enabled by default, so these options are no longer needed
- no tracking should change as a result of this change
@andysellick andysellick force-pushed the remove-ga4-tracking-true branch from b320a04 to 6500698 Compare November 17, 2023 14:08
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2992 November 17, 2023 14:08 Inactive
@andysellick andysellick requested a review from AshGDS November 17, 2023 14:26
@andysellick andysellick merged commit 1b47328 into main Nov 20, 2023
6 checks passed
@andysellick andysellick deleted the remove-ga4-tracking-true branch November 20, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants