Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user research banner to benefits pages #2948

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add user research banner to benefits pages #2948

merged 1 commit into from
Oct 11, 2023

Conversation

catalinailie
Copy link
Contributor

@catalinailie catalinailie commented Oct 5, 2023 •
edited
Loading

The banner will be displayed on the following pages:

  • /disability-living-allowance-children
  • /help-with-childcare-costs
  • /financial-help-disabled
  • /pip
  • /blind-persons-allowance
  • /dla-disability-living-allowance-benefit
  • /carers-allowance
  • /carers-credit
  • /maternity-pay-leave
  • /paternity-pay-leave
  • /child-benefit
  • /jobseekers-allowance
  • /universal-credit
  • /employment-support-allowance
  • /benefits-calculators

Before:
Screenshot 2023-10-06 at 15 58 46

After:
Screenshot 2023-10-10 at 13 46 05

Trello card: https://trello.com/c/wMUxokll/2135-benefits-pages-user-research-banner-request-set-up-m

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2948 October 5, 2023 11:16 Inactive
@catalinailie catalinailie force-pushed the add-benefits-research-banner branch from 0fc4d55 to 7c7e640 Compare October 6, 2023 14:43
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2948 October 6, 2023 14:43 Inactive
hannako
hannako reviewed Oct 6, 2023
View reviewed changes
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up and getting it done so speedily!!

app/presenters/content_item/recruitment_banner.rb Outdated Show resolved Hide resolved
app/presenters/content_item/recruitment_banner.rb Show resolved Hide resolved
app/presenters/content_item/recruitment_banner.rb Outdated Show resolved Hide resolved
@catalinailie catalinailie force-pushed the add-benefits-research-banner branch from 7c7e640 to 4e5e004 Compare October 9, 2023 15:28
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2948 October 9, 2023 15:29 Inactive
@catalinailie catalinailie marked this pull request as ready for review October 10, 2023 12:46
@catalinailie catalinailie requested a review from hannako October 10, 2023 12:46
@catalinailie catalinailie force-pushed the add-benefits-research-banner branch from 4e5e004 to b38b7d5 Compare October 10, 2023 14:51
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2948 October 10, 2023 14:51 Inactive
hannako
hannako approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catalinailie catalinailie merged commit 986dec6 into main Oct 11, 2023
6 checks passed
@catalinailie catalinailie deleted the add-benefits-research-banner branch October 11, 2023 09:55
@hannako hannako mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannako hannako hannako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catalinailie @hannako @govuk-ci