Change GA4 type on service manual contents list #2944
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
requested changes
Oct 4, 2023
| @@ -69,7 +69,7 @@ | |||
| data-ga4-set-indexes | |||
| data-ga4-link="<%= { | |||
| event_name: "navigation", | |||
There was a problem hiding this comment.
Hi @andysellick - isn't event_name meant to be select_content, and the type contents list?
There was a problem hiding this comment.
Checked with Harriet and it should be event_name = select_content and type = contents list.
There was a problem hiding this comment.
So exactly what you said 😁
- should be 'select content'
andysellick
force-pushed
the
ga4-adjust-sm
branch
from
a5dcb44 to
14a487b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the GA4 type on the contents list on pages like https://www.gov.uk/service-manual/helping-people-to-use-your-service/making-your-service-accessible-an-introduction#make-non-digital-parts-of-your-service-accessible to 'select content'.
Why
These are in-page navigation events.
Visual changes
None.
Trello card: https://trello.com/c/kPQBqdSw/675-change-contents-navigation-selectcontent-event-types-to-contents-list