Search tracking for manual pages #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
requested changes
Oct 3, 2023
| @@ -31,10 +29,8 @@ | |||
| <%= render 'govuk_publishing_components/components/metadata', metadata_with_ga4_tracking %> | |||
|
|
|||
| <div class="in-manual-search"> | |||
| <form action="/search/all" > | |||
|
|
|||
| <form action="/search/all" data-module="ga4-form-tracker" data-ga4-form='{ "event_name": "search", "type": "content", "section": "<%= content_item.title %>", "action": "search" }'> | |||
There was a problem hiding this comment.
It might be worth using .to_json to build this, as if the content_item.title contains a double quote, it looks like the tracking breaks.
E.g.
<% test_title = "This has an \" escaped quote in it"%>
<form action="/search/all" data-module="ga4-form-tracker" data-ga4-form='{ "event_name": "search", "type": "content", "section": "<%= test_title %>", "action": "search" }'>
<input type='hidden' name="manual[]" value="<%= content_item.base_path %>">Returns this on submit
GA4 configuration error: Expected ',' or '}' after property value in JSON at position 71 (line 1 column 72) Location {ancestorOrigins: DOMStringList, href: 'http://127.0.0.1:3090/hmrc-internal-manuals/compliance-handbook/ch160200', origin: 'http://127.0.0.1:3090', protocol: 'http:', host: '127.0.0.1:3090', …}Also, the search term is coming through as [redacted] - is that correct?
Thanks
There was a problem hiding this comment.
Good shout, thanks for spotting that, have reworked.
Going to go back to the PAs on the search term - you're probably right, we should should capture it but process it for PII.
- adds GA4 tracking to search forms on manual pages - including manuals e.g. https://www.gov.uk/guidance/understanding-your-driving-test-result/car-driving-test - and manual section e.g. https://www.gov.uk/guidance/understanding-your-driving-test-result/car-driving-test - and hmrc manual e.g. https://www.gov.uk/hmrc-internal-manuals/capital-gains-manual
andysellick
force-pushed
the
ga4-search-tracking
branch
from
48a9d4e to
22ffe71
Compare
AshGDS
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Part of the GA4 migration.
Visual changes
None.
Trello card: https://trello.com/c/zZGLn0tw/694-search-enhancement-add-search-form-tracking-to-manual-manualsection-and-hmrcmanualsection-pages