Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GA4 type from 'content' to 'print page' on print links #2938

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Sep 28, 2023

What

  • Changes the GA4 type on certain print links from content to print page
  • Has a do not merge as this will be auto deployed so I'll need to check with the PAs first

Why

https://trello.com/c/999SSkPq/681-change-view-a-printable-version-navigation-event-types-to-print-page

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@AshGDS AshGDS self-assigned this Sep 28, 2023
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-2938 September 28, 2023 11:10 Inactive
@AshGDS AshGDS marked this pull request as ready for review September 28, 2023 13:06
@AshGDS AshGDS requested a review from andysellick September 28, 2023 13:07
@AshGDS AshGDS changed the title [DO NOT MERGE] Change GA4 type from 'content' to 'print page' on print links Change GA4 type from 'content' to 'print page' on print links Oct 4, 2023
@AshGDS AshGDS merged commit aea97f6 into main Oct 4, 2023
@AshGDS AshGDS deleted the ga4-change-print-type branch October 4, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants